Contrib.social

TypeError: Drupal\Core\Entity\EntityRepository::getTranslationFromContext(): Argument #1 ($entity) must be of type Drupal\Core\Entity\EntityInterface, null given

Open on Drupal.org →
Created on 21 January 2025, 2 months ago

Describe your bug or feature request.

This happens on selecting a product from a product entity browser, but does not happen in all our environments. The full error is:
TypeError: Drupal\Core\Entity\EntityRepository::getTranslationFromContext(): Argument #1 ($entity) must be of type Drupal\Core\Entity\EntityInterface, null given, called in /var/www/upgrade/pcms/site/modules/contrib/commerce/modules/product/src/ProductVariationAttributeMapper.php on line 89 in Drupal\Core\Entity\EntityRepository->getTranslationFromContext() (line 94 of /var/www/upgrade/pcms/site/core/lib/Drupal/Core/Entity/EntityRepository.php)

The error trail does not include any custom code or any other contrib modules - just core and commerce.

If a bug, provide steps to reproduce it from a clean install.

The steps are:
Launch the product entity browser
Select a product
The site returns to the page that called the browser with the following message:
Oops, Something went wrong. Check your browser’s developer console for more details
The console only shows a parse error to an ajax call but the drupal log provides the error reported above.

Suspicion

The relevant code is the following lines:
/** @var \Drupal\commerce_product\Entity\ProductAttributeInterface $attribute */
$attribute = $this->attributeStorage->load($attribute_ids[$index]);
// Make sure we have translation for attribute.
$attribute = $this->entityRepository->getTranslationFromContext($attribute, $selected_variation->language()->getId());
The load can return a null but this is not tested before passing to getTranslationFromContext.
We can test it and ignore that field if it happens but this might be masking.
I will supply a patch to test for null for now once it is ready.

🐛 Bug report
Status

Active

Version

2.40

Component

Product

Created by

🇬🇧United Kingdom Rory Downes

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024