Remove the 'manage registrations' operation

Created on 17 January 2025, 3 months ago

Problem/Motivation

Working on ✨ Create additional host permissions Active I came to think that:
- The 'manage broadcast' host operation should be just 'broadcast'
- The 'manage registrations' host operation should be removed. It's not really needed as an operation, it's just a consequence of me being a bit literal when creating these operations based on existing permissions. Access checking for the /{host}/registrations route should depend on the user having access to either the 'view registrations' or 'manage settings' or 'broadcast' host operations.

It's unlikely that there are any sites in the wild depending on these operation names as they were only recently released, but I could add a BC layer easily enough.

I don't think this is important, so I'm ok with won't fix if that's your preference.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

3.3

Component

Registration Core

Created by

πŸ‡¬πŸ‡§United Kingdom jonathanshaw Stroud, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jonathanshaw
  • πŸ‡ΊπŸ‡ΈUnited States john.oltman

    I'm unclear on this, as it is possible for someone to not have access to settings, broadcast, or view registrations, and still have access to the manage registrations tab. In this case it shows a summary. So I'm not certain of the changes this issue could make. As for the operation name "broadcast" this would seem to imply the "manage settings" (does that exist?) operation would become just "settings" which doesn't seem right.

    At a minimum, I think we need a list of the currently accepted operation names in a comment somewhere in RegistrationHostAccessControlHandler.

  • πŸ‡¬πŸ‡§United Kingdom jonathanshaw Stroud, UK

    it is possible for someone to not have access to settings, broadcast, or view registrations, and still have access to the manage registrations tab. In this case it shows a summary.

    Yes. Perhaps you're right that for BC we should keep an operation just for this. It's slightly annoying as it seems a slightly trivial thing to have an operation for.

    I lean towards thinking that the operation should be called "view registrations summary" as that is what the operation is actually about. It doesn't really allow you to "manage registrations" in any obvious sense of what it might mean to "manage" a registration; it isn't even considered when considering access to individual registrations, unlike 'view registrations', update registrations', 'administer registrations' etc.

    As for the operation name "broadcast" this would seem to imply the "manage settings" (does that exist?) operation would become just "settings" which doesn't seem right.

    I considered that but couldn't think of a good single word verb for "manage settings". "configure" isn't awful but has a somewhat different meaning in Drupal.

    But even if we have to leave "manage settings" as two words, that doesn't mean "broadcast" isn't better than "manage broadcast" for the operation. But I accept that it might well not be worth changing.

  • πŸ‡ΊπŸ‡ΈUnited States john.oltman
Production build 0.71.5 2024