- Issue created by @_renify_
- First commit to issue fork.
- Merge request !17Issue #3500094: Add fallback values to module configurations. ā (Merged) created by heikkiy
- š«š®Finland heikkiy Oulu
Thank you for reporting this. We noticed similar issues before releasing 1.2.0 but seems we missed this part.
I created a merge request and added fallback values for this and a couple more new configs.
Does this MR fix your issue?
- š«š®Finland heikkiy Oulu
Added other fallback values also and all pipelines are now passing.
- š®š³India akulsaxena
Tried reproducing the issue, was able to reproduce it
Applied the patch from the MR and it fixes the issue
All pipelines are also green
Moving it to RTBC+ - š«š®Finland heikkiy Oulu
Excellent thanks. I added a couple more automated tests to make sure that the default empty settings also work. We will try to get 1.2.1 released ASAP.
Iām unable to reproduce the issue as described. There is an update hook (piwik_pro_update_9102()) that writes the configurations, so they should not be null if the update has been applied. Additionally, after saving the configuration form, the configurations are always populated with the corresponding values.
Could it be that the workflow is more complex than described in the task? In any case, the fix seems fine.
-
heikkiy ā
committed 4cd307e6 on 1.2.x
Issue #3500094 by heikkiy, _renify_, akulsaxena, dimas11: TypeError:...
-
heikkiy ā
committed 4cd307e6 on 1.2.x
Automatically closed - issue fixed for 2 weeks with no activity.