Layout Builder time outs with new version of editoria11y

Created on 15 January 2025, 3 months ago

Problem/Motivation

When editing in layout builder, the new editoria11y module appears to degrade performance to the point that the browser times out.

This is likely dependent on how much content you have in the layout builder layout as well as the custom theme in use as well as what exclusionary rules are in place. However, even with the new "live check" option disabled, syncing disabled, and everything outside of the main system content block excluded, editing in layout builder wasn't really possible.

Would the maintainers have any other suggestions to reduce the performance burden of the new module release?

Steps to reproduce

Install the latest module release and attempt to edit a page with multiple sections/block types in layout builder.

πŸ’¬ Support request
Status

Active

Version

2.2

Component

Conflicts with other modules

Created by

πŸ‡ΊπŸ‡ΈUnited States jastraat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jastraat
  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    That's...profoundly troubling. Editoria11y is supposed to disable itself if it detects the Layout Builder editor interface is present on the page (.layout-builder-form) -- I learned during the beta that Layout Builder has scroll listeners that make it incompatible with another module modifying the page markup -- it results in what you describe. Something is very wrong if Editoria11y is running while Layout Builder is open.

    Could you tell me what Editoria11y version you are on, what version of Drupal core you are on, and, if you are up for checking your browser console, whether anything is found if you type document.querySelector('.layout-builder-form')?

    • itmaybejj β†’ committed 3209d265 on 2.2.x
      Issue #3500093 by jastraat, itmaybejj: Layout Builder time outs with new...
  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    I realized -- even though I was not initializing the library on Layout Builder editor routes, I was still attaching the library. It doesn't do any harm to be there if the auto-disablement works, but it's needless. This commit will prevent it from even attaching to those routes.

  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    Please test 2.2.3. If you type "Ed11y" in the console you can see if the library is loaded. It should not be present on the Layout tab.

    If your editing environment loads Layout Builder forms on other routes, it would help me to know what the route names are, and/or what CSS selector reliably detects your forms.

  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    Thank you so much! This seems to have addressed the issues we were having with layout builder.

    When checking in the console with Ed11y I see it loaded when viewing content on the view tab or the edit tab but not the layout tab.

    Thanks again for the quick response!

  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    Huzzah! Thank you for finding and testing.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024