[2.0.0-rc2] Move the ComponentMetadata::parseSchemaInfo() workaround to the Schema Manager

// Because of SDC's ComponentMetadata::parseSchemaInfo() which is adding // "object" type to all props to "allows deferring rendering in Twig to the // render pipeline". Remove it as soon as this weird mechanism is removed // from SDC. if (in_array("integer", $this->propDefinition["type"])) { $form['value']['#step'] = 1; }

$normalized_prop_schema['type'] = SdcPropJsonSchemaType::from( // TRICKY: SDC always allowed `object` for Twig integration reasons. // @see \Drupal\sdc\Component\ComponentMetadata::parseSchemaInfo() is_array($prop_schema['type']) ? $prop_schema['type'][0] : $prop_schema['type'] )->value;

Comments & Activities

Issue created by @pdureau
Comment 6 days ago →
🇫🇷France pdureau Paris
Not possible to move it to the Schema Manager's Canonicalizer, because Canonicalizer service is called (from ComponentPluginManager::annotateProp() to PropTypePluginManager::getDefinitionFromSchema() to CompatibilityChecker::isCompatible()) before ComponentMetadata::parseSchemaInfo() is executed (ComponentPluginManager::createInstance() to Component::__construct() to ComponentMetadata::__construct()).

I have tried to alter it by overriding ComponentPluginManager::createInstance() but everything is read-only.

So, I guess we need to fix this directly in SDC with a Core issue, by simply removing:

// All props should also support "object" this allows deferring rendering // in Twig to the render pipeline. $schema_props = $metadata_info['props']; foreach ($schema_props['properties'] ?? [] as $name => $prop_schema) { $type = $prop_schema['type'] ?? ''; $schema['properties'][$name]['type'] = array_unique([ ...(array) $type, 'object', ]); }
Comment 3 days ago →
🇫🇷France pdureau Paris

[2.0.0-rc2] Move the ComponentMetadata::parseSchemaInfo() workaround to the Schema Manager

Problem/Motivation

Proposed resolution

API changes

Comments & Activities