- Issue created by @dcam
- πΊπΈUnited States dcam
Test case 9 had a couple of problems:
- It seemed to be trying to test two different things:
- A blocked existing user
- A mismatch in the
sub
property
The test path was not compatible with doing this. The "mismatch" case results in an early return, but then the test path expected function calls related to the blocked user. I had to make the assumption that these cases should be tested separately. It's difficult to know whether they should since there's no labels or comments on the test cases to know what the original intent was. Based on the current
completeAuthorization()
code it makes sense to me that they should not be tested together. I split the "mismatch" case into a new 10th test case. - The test path was not set up to test for the
sub
mismatch.
- It seemed to be trying to test two different things:
- First commit to issue fork.
- πΊπΈUnited States pfrilling Minster, OH
I fixed the deprecations that were flagged for the next minor. I think this looks good.
- πΊπΈUnited States pfrilling Minster, OH
Merged the PR. Thanks for getting those tests enabled!
-
pfrilling β
committed 7799c7dd on 3.x authored by
dcam β
Issue #3499535 by dcam, pfrilling: Uncomment test cases in...
-
pfrilling β
committed 7799c7dd on 3.x authored by
dcam β
Automatically closed - issue fixed for 2 weeks with no activity.