I was working on some additions to a service where I implemented PHP's constructor property promotion. That led me down a bit of a rabbit hole. I figured that while I was at it I might as well promote the other constructor properties. Then I thought that I should inject the module's logger channel service instead of calling it in the constructor.
It turned out that I didn't need to do those changes for what I was attempting at the time, but I don't want to lose that work. It removes a TON of boilerplate code. So I'm saving it off here.
* Decide whether you want to do this.
* Decide whether you want to move forward with doing property promotion in all the other classes at this time or merge it as-is.
* Do any additional work.
There's an argument for not getting the User storage in the OpenIDConnect service constructor too, but I left that alone. @larowlan can explain why it's a good idea better than I can. I'm sure he has a blog entry on it, but I can't find it.
Service dependency changes.
Active
3.0
Code