Contrib.social

ResettablePageCache overrides other service decorators

Open on Drupal.org →
Created on 13 January 2025, 3 months ago

Problem/Motivation

The ResettablePageCache uses service decoration to add the reset functionality to Drupal's page cache. It does this by defining itself as a subclass of PageCache. However, the inner service is not passed into the new decorating service, so any other decorating services are lost. Essentially, ResettablePageCache overrides inner services.

Also, PageCacheRequestPrepareSubscriber assumes the page cache will always be an instance of ResettablePageCache, but will not be if there is an outer service decoration.

Steps to reproduce

  1. Enable this module.
  2. Enable another module that decorates the PageCache (like Big Pipe or a custom page cache) and give it a higher decoration priority.
  3. Attempt to use the functionality of the other decorating service, and notice it does not work.

Proposed resolution

  • Update pass the inner service to ResettablePageCache, and call the methods of that inner service.
  • Update PageCacheRequestPrepareSubscriber to accept any instance of HttpKernelInterface, so a service with lower priority can decorate the chain.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.12

Component

Code

Created by

🇺🇸United States byrond

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024