Make all tests declare strict_types

Open on Drupal.org →

Created on 10 January 2025, 3 months ago

Problem/Motivation

Some of our tests declare(strict_types=1);, and some don't.

Drupal Core already requires that All tests must declare the use of strict types → : we should probably do that too.

Proposed resolution

Add declare(strict_types=1); to existing tests that don't have them. Fix any issues that show up.

Remaining tasks

Write a patch
Review and feedback
RTBC and feedback
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

✨ Feature request

Status

Active

Version

8.0

Component

Code

Created by

🇨🇦Canada mparker17 UTC-4

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!77Make all tests declare strict_types
Merged
🇨🇦Canada mparker17
updated 3 months ago

Comments & Activities

Issue created by @mparker17
Merge request !77Issue #3498806: Make all tests declare strict_types → (Merged) created by mparker17
Comment 3 months ago →
🇨🇦Canada mparker17 UTC-4
Looking good to me.
Comment 3 months ago →
System Message

mparker17 → committed 8060ce48 on 8.0.x
Issue #3498806 by mparker17: Make all tests declare strict_types
Comment 3 months ago →
🇨🇦Canada mparker17 UTC-4
Merged!
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment 2 months ago →
🇨🇦Canada mparker17 UTC-4
Note this was released in elasticsearch_connector-8.0.0-alpha3 → .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024