- Issue created by @m.stenta
- First commit to issue fork.
- π¦πΊAustralia elc
Fixed up the one test that was held up just by an admin ui change that needed to click differently named buttons.
Will leave fixing up the phpcs/cspell issues for π Fix the issues reported by phpcs Needs work once this is merged.
I can see that you committed
OPT_IN_TEST_MAX_PHP: 1
but it has disappeared without a corresponding commit or change. - πΊπΈUnited States m.stenta
Thanks for fixing the test @elc! That was a nice notification to wake up to. :-)
I can see that you committed
OPT_IN_TEST_MAX_PHP: 1
but it has disappeared without a corresponding commit or change.I added that commit and then rolled it back and force pushed. I figured keep things simple for now. We need to get the Drupal 11 release ( π Automated Drupal 11 compatibility fixes for fraction Needs work ) completed first I think. Then we can set
OPT_IN_TEST_CURRENT: 1
andOPT_IN_TEST_MAX_PHP: 1
at the same time IMO.There's one last thing I would like to add to this MR. We used to test this module against multiple databases. So I will push a commit to implement that, and we can make sure everything is still passing...
-
m.stenta β
committed 29da671c on 2.x
Issue #3498271 by m.stenta, elc: Enable GitLab CI integration
-
m.stenta β
committed 29da671c on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.