- Issue created by @slasher13
- ee611201 committed on 2.3.x
Issue #3498194 by slasher13, lhridley: Route requirement boolean values...
- ee611201 committed on 2.3.x
- πΊπΈUnited States lhridley
Expanded context of issue for all defined key / values.
- π©πͺGermany slasher13
But this is not true see https://www.drupal.org/docs/drupal-apis/routing-system/structure-of-routes β
e.g. '_maintenance_access' and '_disable_route_normalizer' are boolean and not a string. - πΊπΈUnited States lhridley
@slasher13 -- looking into this further, I'm finding conflicting documentation on this so I've reached out for clarification.
- πΊπΈUnited States lhridley
No clarification yet, but in searching through projects that we support at work, found the following similar implementation for another contrib module:
ckeditor5_icons module: https://git.drupalcode.org/project/ckeditor5_icons/-/blob/1.x/src/Routin...
public function getRoutes() { return [ 'ckeditor5_icons.fontawesome6_metadata' => new Route( '/' . $this->service->getFontAwesomeMetadataPath('6'), [ '_controller' => 'Drupal\ckeditor5_icons\Controller\MetadataController::getFontAwesome6MetadataResponse', '_format' => 'json', '_disable_route_normalizer' => 'TRUE', ], [ '_csrf_token' => 'TRUE', ] ), .... ];
If no clarification is received, I'll revise the committed work to remove the single quotes from
_maintenance_access
, but will leave them in place for_disable_route_normalizer
.I hate inconsistencies ... drives my OCD insane :)
- c541cd49 committed on 2.3.x
Issue #3498194 by slasher13: Corecting the Route requirement boolean...
- c541cd49 committed on 2.3.x
- πΊπΈUnited States lhridley
Final update: didn't really receive any guidance, but a discussion in Slack was helpful. I decided to evaluate the Redirect module, which is the only module I was able to locate that actually used this key value pair in code, and given that this is a configuration setting for routes, I'm going with that as my assumption for correctness.
Redirect sets the same value in the same context as a boolean and evaluates it as such, so boolean it is.
@slasher13, I pushed a correction.