Drupal\project_browser\Element\ProjectBrowser::getDrupalSettings() on a Drupal CMS install (just the starter kit), takes about 16 seconds and several megabytes of memory. See xhprof screenshot below.
This happens every time you refresh the page.
Install Drupal CMS in ddev, enable xhprof, browse to https://drupal-cms-dev.ddev.site/admin/modules/browse/recipes.
This is all from:
$package_manager = array_merge($package_manager, $this->installReadiness->validatePackageManager());
It must be possible to cache this, if installing or updating a module invalidates it, that might be enough?
But also given it's so expensive to generate, it would be better if it could be calculated outside the critical path. Since it's used in Drupal settings and only required on project browser pages, could it moved to an AJAX request and then populate drupal settings from there? Although it would still need the caching too.
Active
2.0
Code
It affects performance. It is often combined with the Needs profiling tag.
It shouldn't even be running the stupid Package Manager validation. It only does that because of an old sledgehammer-approach decision.
This should be fixed in 🐛 Package Manager validation is only necessary if the project to install is not already in the filesystem Active .
Not running at all is a lot better than caching. I think we can just mark this duplicate.