- Issue created by @kir.lazur@gmail.com
- First commit to issue fork.
- Merge request !76Issue #3497968: Merging Multiple Facet Conditions in facets_post_filters with OR Conjunction β (Open) created by mparker17
- π¨π¦Canada mparker17 UTC-4
@kir lazur, thank you very much!
I've created a merge request from your patch and credited you as the author.
Are you comfortable writing automated tests? If not, I'd be happy to help!
- π¨π¦Canada mparker17 UTC-4
Are you comfortable writing automated tests?
I should probably clarify: I fixed the test that broke after applying your patch (i.e.: changing
tag
totags
in the constructed query).... But a test for the exact scenario you were running into in the issue description doesn't exist yet, and we should create one, so that the behavior that you rely on doesn't regress in the future!
(housekeeping: now that there's an issue fork, I'm hiding the old patch; and I'm moving the issue to
Needs work
and adding the tagNeeds tests
) - π§πΎBelarus dewalt
I'm not sure that collect "terms" key is universal solution. It definitely works with simple string facet, but it could have issues if "exclude" options is enabled in facet or it is range or match facet.
I propose to collect all the filters and apply it to "agg" syntax. If filters works with "query" section so it should work here too.
Need to be tested with complex, negation facets and with ones with "exclude" option configured.