Improve maximum spaces validation

This uses Registration::getAdditionalSpacesRequested() so postponed on 📌 Explore alternatives to passing existing registration into hasRoom Active .

john.oltman → made their first commit to this issue’s fork.

I still need to add tests to prove an existing registration won't trigger the maximum spaces error in certain use cases. Otherwise you can take a look and see what you think. I'll get those tests added later today.

john.oltman → changed the visibility of the branch 3497963-improve-maximum-spaces to hidden.

Test added, all set. If you look at the last pipeline, you'll see a failure on the last stage - that is from the "test-only changes" - I ran that to make sure I proved there was a real issue before - and then you can see the phpunit test with all the code from the MR, that passed. Not sure how familiar you are with "test only changes" but that means it applies just the test files in the MR and runs all tests - so you can prove that a problem really did exist.

This feels like a win to me, and would mean we could close 📌 Explore alternatives to passing existing registration into hasRoom Active .

Looks good

Automatically closed - issue fixed for 2 weeks with no activity.

john.oltman → closed merge request !89