- Issue created by @collinhaines
- π¨π¦Canada awasson
I can affirm that this is an issue that occurred between core versions Drupal 10.3 and Drupal 10.4.
Every one of my Drupal sites that were updated to Drupal 10.4 have lost the ability to access the IMCE file manager from the Core CKEditor image tool.
I don't see any errors in the Javascript console or the error database and the CKEditor has been set for Images not to use the upload feature in Core which should enable IMCE to work with it. Something must have been changed in core to disable IMCE integration.
Cheers,
Andrew - First commit to issue fork.
- Merge request !36Update core image integration for ckeditor 5 44.0.0+ β (Merged) created by justcaldwell
- πΊπΈUnited States justcaldwell Austin, Texas
I opened an MR with an update that's working for us. I've only done initial testing, and I'm not in a position to easily test with ckeditor < 44.0.0 -- hence the 'draft' MR status.
Please test/review if you're able.
- πΊπΈUnited States justcaldwell Austin, Texas
Attaching a static patch.
- πΊπΈUnited States justcaldwell Austin, Texas
Marked MR as ready. Given that the previous code remains, this should still work with previous versions.
- πΊπΈUnited States noahterp
From a quick test using the #6 patch, an additional IMCE button will be injected each time you close and reopen the "Insert image via URL" dialog. So you could end up with lots of redundant buttons when editing a page.
Best solution I can think of would be to set a flag, e.g.
let imceButtonAdded = false;
in the class. Check that it'sfalse
before injecting the button, and set it totrue
when it's added. - πΊπΈUnited States justcaldwell Austin, Texas
My mistake -- I should've used
.once()
instead of.on()
. MR updated.Thanks for testing!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
6 days ago 6:27pm 7 March 2025 - πΊπΈUnited States stevenpatz Alexandria VA
Drupal 10.4.3
IMCE 3.1.2Cleared browser and Drupal cache. I still only see the URL entry, there's no button to open IMCE.
- π¨π¦Canada awasson
@stevenpatz, I have the same versions of Drupal and IMCE as you and it is working correctly on mine. Did you disable image uploads in Configuration -> Content Authoring -> Text Formats and Editors ? Under image, enable image uploads should be unchecked.
- πΊπΈUnited States stevenpatz Alexandria VA
Yeah that setting matches what I have as well.
- πΊπΈUnited States stevenpatz Alexandria VA
Update: When I use Chrome, the icon does not show up. But using Firefox it does.
- π¨π¦Canada awasson
It must be a caching issue. I'm using Chrome primarily but I also use FF and Edge and it appears normal. I'm on Mac OS. Perhaps there is an issue with Windows/Chrome but I haven't been made aware of it by any of my clients who are on Windows and use Chrome.
- πΊπΈUnited States stevenpatz Alexandria VA
Yeah I think it's a local issue, as I had our QA go thru and they saw it on Chrome and Firefox