- Issue created by @milanbombschliip
- Merge request !28Issue #3497629: Add new rokka_video media source so rokka video can generate a thumbnail on save. → (Merged) created by milanbombschliip
- Issue was unassigned.
- First commit to issue fork.
- 🇧🇬Bulgaria pfrenssen Sofia
It looks like existing videos will not have their thumbnails updated, and it does not seem easy to do this in an update hook, because the
Media::updateThumbnail()
method is protected. There is an issue about this but it is still in progress: ✨ Expose triggering update of media metadata + thumbnail to end users Needs review . - 🇧🇬Bulgaria pfrenssen Sofia
We need to check that newly added videos also get a thumbnail. So far I only tested with existing videos.
- 🇨🇭Switzerland milanbombschliip
Okay, newly added videos also do get thumbnails. I forgot to switch from
source: video_file
tosource: rokka_video
inconfig/default/media.type.video.yml
- 🇧🇬Bulgaria pfrenssen Sofia
@milanbombschliip: there is a post-update hook that should take care of updating the media source. Didn't it work?
- 🇨🇭Switzerland milanbombschliip
@pfrenssen Hmm, now when trying to debug it everything worked fine. The source type got set by the post-update hook and drush cex showed the change and thumbnail picture show up for newly added videos. Not really sure what was going on earlier on my side.
-
pfrenssen →
committed 26ec1477 on 3.x authored by
milanbombschliip →
[#3497629] feat: Add Thumbnails in Media Library for videos By:...
-
pfrenssen →
committed 26ec1477 on 3.x authored by
milanbombschliip →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- 🇧🇬Bulgaria pfrenssen Sofia
Thanks for confirming, and for the great contribution! This is an awesome new feature :)