Contrib.social

Accessing state service in container build time breaks the update process unexpectedly

Open on Drupal.org →
Created on 3 January 2025, 3 months ago

Problem/Motivation

After upgrading projects from Drupal 10.2 to 10.3 (Related: State service now uses a cache collector for performance → ?), we encountered unexpected errors during the execution of drush updb. Notably, this issue occurs even when there are no pending updates on the site.

The stack trace for the error is as follows:

$ drush updb
 [success] No pending updates.
 [error]  TypeError: Drupal\views\ViewExecutable::setRequest(): Argument #1 ($request) must be of type Symfony\Component\HttpFoundation\Request, null given, called in /var/www/html/core/modules/views/src/ViewExecutableFactory.php on line 79 in Drupal\views\ViewExecutable->setRequest() (line 1864 of /var/www/html/core/modules/views/src/ViewExecutable.php) #0 /var/www/html/core/modules/views/src/ViewExecutableFactory.php(79): Drupal\views\ViewExecutable->setRequest()
#1 /var/www/html/core/modules/views/src/Entity/View.php(123): Drupal\views\ViewExecutableFactory->get()
#2 /var/www/html/core/modules/views/src/EventSubscriber/RouteSubscriber.php(116): Drupal\views\Entity\View->getExecutable()
#3 [internal function]: Drupal\views\EventSubscriber\RouteSubscriber->routes()
#4 /var/www/html/core/lib/Drupal/Core/Routing/RouteBuilder.php(146): call_user_func()
#5 /var/www/html/core/lib/Drupal/Core/ProxyClass/Routing/RouteBuilder.php(83): Drupal\Core\Routing\RouteBuilder->rebuild()
#6 /var/www/html/core/includes/common.inc(454): Drupal\Core\ProxyClass\Routing\RouteBuilder->rebuild()
#7 /var/www/html/vendor/drush/drush/src/Commands/core/UpdateDBCommands.php(96): drupal_flush_all_caches()
#8 [internal function]: Drush\Commands\core\UpdateDBCommands->updatedb()
#9 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#10 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#11 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#12 /var/www/html/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process()
#13 /var/www/html/vendor/symfony/console/Command/Command.php(279): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#14 /var/www/html/vendor/symfony/console/Application.php(1094): Symfony\Component\Console\Command\Command->run()
#15 /var/www/html/vendor/symfony/console/Application.php(342): Symfony\Component\Console\Application->doRunCommand()
#16 /var/www/html/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRun()
#17 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run()
#18 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#19 /var/www/html/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run()
#20 /var/www/html/vendor/bin/drush.php(119): include('...')
#21 {main}.

Steps to reproduce

1. Create a compiler pass that accesses the state service during the container build process. Use the following example:

final class TestCompilerPass implements CompilerPassInterface {

  public function process(ContainerBuilder $container) {
    $container->get('state');
  }

}

2. Register this compiler pass in your project.
3. Execute drush updb or an equivalent command to start the update process.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

base system

Created by

🇭🇺Hungary mxr576 Hungary

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mxr576
  • Merge request !10780Draft: POC → (Open) created by mxr576
  • Comment 3 months ago →
    🇭🇺Hungary mxr576 Hungary
  • Pipeline finished with Failed
    3 months ago
    Total: 411s
    #384678
  • Pipeline finished with Failed
    3 months ago
    Total: 608s
    #384695
  • Merge request !10782Draft: Resolve #3497123 "Fix" → (Open) created by mxr576
  • Pipeline finished with Running
    3 months ago
    #384736
  • Pipeline finished with Failed
    3 months ago
    Total: 343s
    #384757
  • Pipeline finished with Failed
    3 months ago
    Total: 375s
    #384788
  • Pipeline finished with Failed
    3 months ago
    Total: 488s
    #384796
  • Comment 3 months ago →
    🇭🇺Hungary mxr576 Hungary

    Related Slack thread: https://drupal.slack.com/archives/C1BMUQ9U6/p1735897088083149

    Also attached the textual representation created via Slack dump.

    AI summary:

    Participants discuss the problems, including:

    1. **State Service Issues**: It has become problematic to access the `state` service during container build time due to caching mechanisms and service dependencies.

    2. **Race Conditions and Alternatives**: Mention of related issues like race conditions in development, alternative storage options like key-value storage, and container parameters for performance and minimal complexity.

    3. **Testing and Failures**: Observations that the update system and session storage break when `state` is used in compiler passes. Failed tests highlight specific issues triggered by `state` usage.

    4. **Recommendations and Challenges**: Advice is given to use key-value storage cautiously and ensure cache clearance. However, achieving this in compiler passes presents challenges due to potential outdated information being cached.

    5. **Codebase Observations**: A null return from `$this->requestStack->getCurrentRequest()` was identified as a potential unhandled issue in Drupal core, exacerbated by using `state` in compiler passes.

    6. **Discussion on Feasibility**: Some participants recommend changing direction entirely due to the complexities and risks involved.

  • Comment 3 months ago →
    🇨🇦Canada Charlie ChX Negyesi 🍁Canada

    what has the world come to that drupal issues are utilizing ai summaries I thought y'all are better than this

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024