Improve test coverage for role visibility

Merge request is updated and pipelines seem to be passing. This still needs manual review.

Marking this as Needs work because it seems to give the PHP error if you install the new code but don't save the module settings.

This is now changed and looks good.