- Issue created by @penyaskito
- Merge request !49Issue #3495987: Convert hooks to the new OOO system → (Merged) created by penyaskito
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
With the current MR we require ^11.1.
Not sure if we want to keep the legacy hooks to maintain compatibility with ^10.4. - 🇪🇸Spain plopesc Valladolid
I really like how the code looks in the MR, but I feel that bumping core requirements to ^11.1 might be controversial.
We could maybe explore the
#[LegacyHook]
approach to increase the number of sites that could adopt Dashboard module in this initial phase and gain more traction across the community. Removing those extra BC bits should be easy once we definitely remove 10.x support at some point.If we decide to bump the requirements, we could get rid of the conditional logic to handle login in
DashboardRedirectAfterLoginTest::setup()
. - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
@plopesc TBH I wasn't even sure if merging this before 2.0.0. I added the BC layer, so we might do that, but then I'd tag a rc ASAP.
- 🇪🇸Spain plopesc Valladolid
Made a quick review and added a few comments. Most of them are just cosmetics.
Thank you this one!
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
I wouldn't consider the hook implementations API, so not that concerned about these if need to change anyway.
-
penyaskito →
committed 2eb103cb on 2.x
Issue #3495987: Convert hooks to the new OOP system
-
penyaskito →
committed 2eb103cb on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.