- Issue created by @longwave
- 🇬🇧United Kingdom longwave UK
This is showing some interesting fails in 11.x that need further investigation.
- 🇬🇧United Kingdom longwave UK
At least some of the fails appear to be related to 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Active . Experience Builder creates config entities in
hook_rebuild()
, this means that we can no longer install XB and config that depends on it at the same time.Even setting
container_rebuild_required: true
doesn't help because config validity is checked for the entire set of modules, not per group:// Check the validity of the default configuration. This will throw // exceptions if the configuration is not valid. $config_installer->checkConfigurationToInstall('module', $module_list); // Some modules require a container rebuild before and after install. // Group modules such that as many are installed together as possible until // one needs a container rebuild. $module_groups = []; $index = 0; foreach ($module_list as $module) { // Ensure the container is rebuilt both before and after a module that // requires a container rebuild is installed. $container_rebuild_required = !empty($module_data[$module]->info['container_rebuild_required']);
- 🇬🇧United Kingdom longwave UK
Opened 🐛 Modules that create config cannot be installed alongside modules that depend on that config Active for #5.
Unsure if we actually want to hard fail on errors in 11.x or let them slide for now, as long as we fix them before 11.2 is out we are OK, and chasing HEAD is difficult, especially if core makes a change and MR tests start failing for reasons unrelated to the MR itself. Maybe we should only fail "next minor" on branch tests and not MRs?
- 🇬🇧United Kingdom longwave UK
The fails in ComponentTreeItemTest are also solved by adding
container_rebuild_required: true
to xb_test_config_node_article.info.yml. - 🇬🇧United Kingdom longwave UK
Reverted the fail-on-next-minor change, let's fix that over in 📌 CI: also test against next minor: 11.2.x aka Drupal 11.x HEAD Active
-
wim leers →
committed 2555ca16 on 0.x authored by
longwave →
Issue #3495655 by longwave: CI: update template for Drupal 11.1.0
-
wim leers →
committed 2555ca16 on 0.x authored by
longwave →
Automatically closed - issue fixed for 2 weeks with no activity.