- Issue created by @longwave
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Confirmed: latest nightly run fails in the same way: https://git.drupalcode.org/project/experience_builder/-/jobs/3756953
- 🇬🇧United Kingdom longwave UK
FWIW core excludes
Drupal.Commenting.VariableComment.Missing
for tests, perhaps we should do the same, but keep it for runtime code as it can be useful to actually document things. -
wim leers →
committed 7162b045 on 0.x authored by
longwave →
Issue #3494985 by longwave, wim leers, niharika.s: Update PHPCS rules...
-
wim leers →
committed 7162b045 on 0.x authored by
longwave →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@longwave in #7: I agree it can be useful! But definitely not always.
The majority of the comments that that rule forced us to add were not meaningful; they just restated what the name already said. In core too, more often than not, these comments are actually stale and hence (anywhere between "slightly" and "very") wrong. In XB, I think the combined use of:
- more typed objects
- PHPStan level 8, which then includes array shape definitions
massively reduces the need that once existed. I think that rule made sense in an era before those two things, but not now. The collateral damage is too great.