Contrib.social

Make the filter work in all compatible environments

Open on Drupal.org →
Created on 18 December 2024, 4 months ago

Problem/Motivation

I have had trouble getting the "insert blocks" filter to do anything both in a clean install on gitpod (10.4.0) and on my own project (10.3.1).

I have checked that the following things are present:
- Version of Drupal meets the module requirements
- The filter module is installed and enabled
- The text-format has no other filters applied (to eliminate the chance of adverse interactions)
- composer require symfony/dom-crawler has been executed (at the web root)
- The markup of the inserted block upon publication includes the "insert-blocks" class and the "data-block-id" attribute has a value.

This is all as it should be so the conditions of failure must be something else, either specific to an environment or a theme or certain drupal versions.

Steps to reproduce

Actual steps:

  1. Load up a copy of Drupal with gitpod and this module
  2. Run composer require symfony/dom-crawler
  3. Run drush en ckeditor_insert_blocks
  4. Create a new Text Format, add the "Insert blocks" button and filter.
  5. Create a new Content Block with the contents "ONE"
  6. Create a new Article using the new text format
  7. Insert the Block into the new article and publish
  8. Go back to the content block and change the contents to "TWO"
  9. Run drush cr
  10. Go back to the Article and refresh the page if you haven't already
  11. Observe that the inserted block, inside the article, has not been processed/pre-processed by the filter and still says "ONE", and has so has not been updated to the latest version.

Proposed resolution

As we discussed this issue on slack, I hear that the filter is working in some conditions.

I propose we:

- Establish what those conditions are
- Compare those conditions to the Drupal 10.3-10.4 sandbox.
- Make changes to the code to broaden the compatibility, or
- Update the documentation and the "compatible versions" info to match where the module actually works.

Remaining tasks

- Establish which conditions cause the filter to succeed, and which conditions cause it to fail
- Suggest code changes
- Suggest documentation changes
- Merge request
- Review
- Merge

User interface changes

N/A

API changes

TBC

Data model changes

N/A

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom jacobupal Leeds

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024