Contrib.social

Imagemagick convert command without destinationFile fails

Open on Drupal.org →
Created on 18 December 2024, 4 months ago

Problem/Motivation

Using: Imagemagick 6 (though from a cursory look, v7 might also have the same issue).

Our custom code runs the following command through ImagemagickExecManager, to get an RGB value back on STDOUT. Notably, this has no destination file. The return value on STDOUT is something like 

$ convert /PATH/TO/INPUTFILE[0] -resize 1x1\! -format "%[fx:int(255*r+.5)],%[fx:int(255*g+.5)],%[fx:int(255*b+.5)]" info:-
"129,136,137"

Since 📌 Switch command line escaping to Symfony Process Fixed (i.e. post 8.x-3.6) this does not work anymore, because the destination file is always added to the command. Adding an empty destination file leads to the following (you can try on CLI):

$ convert /PATH/TO/INPUTFILE[0] '-resize' '1x1!' '-format' '"%[fx:int(255*r+.5)],%[fx:int(255*g+.5)],%[fx:int(255*b+.5)]"' 'info:-' ''
convert: no decode delegate for this image format `INFO' @ error/constitute.c/ReadImage/572.
����JFIF``��;CREATOR: gd-jpeg v1.0 (using IJG JPEG v80), quality = 75
��C





 $.' ",#(7),01444'9=82<.342��C


2!!22222222222222222222222222222222222222222222222222�"����������
                                                                 ?����

(The "convert:" line is STDERR, the rest is STDOUT.)

Proposed resolution

Remove the final '' from the command, if $destinationFile is empty; then it works again.

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @roderik
  • Merge request !45Do not add empty destination file as extra parameter to convert CLI command → (Open) created by roderik
  • Comment 4 months ago →
    🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Seeing that graphicsmagick convert works the same way, so I added the same change to buildGraphicsmagickConvertCommand().

    I only tested manually on Imagemagick 6, that this fixes our issue.

  • Pipeline finished with Success
    4 months ago
    Total: 297s
    #372699
  • Status changed to RTBC 29 days ago
  • Comment 29 days ago →
    🇸🇮Slovenia useernamee Ljubljana

    Confirmed that the MR fixes the issue.

  • Comment 28 days ago →
    🇮🇹Italy mondrake 🇮🇹

    Hi, thanks - we would need automated tests here so it's clear the expected behavior (I don't understand is it an image printed on STDOUT, or a text resulting from a function calculation, or what?) and we prevent possible regressions in the future. Suppose this is a side-usage of the toolkit, right? Nothing to do with GDToolkit behavior (canonical 'expected' behavior of a Drupal image toolkit)?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024