- Issue created by @Oulalahakabu
- 🇫🇷France Oulalahakabu
oulalahakabu → changed the visibility of the branch 1.x to hidden.
- Merge request !11#3494692 Adds folder in library base path if exists. → (Open) created by Oulalahakabu
- 🇫🇷France S3b0uN3t Nantes
Hello,
I agree with your remark. I also noticed this at the end of last week.
Wouldn't using
base_path()
be a better choice?I purpose :
$variables['dsfr_path'] = base_path() . ltrim(Dsfr4DrupalInterface::LIBRARY_PATH, '/');
- 🇫🇷France Oulalahakabu
I cannot remember exactly why i always use this trick tbh, looks like SF -and Drupal- since https://github.com/symfony/symfony/pull/37734/commits/109e0a9f1ae68eb8d9... are now better handling prefixes !
Just tested
base_path()
works now, better way ! - 🇫🇷France S3b0uN3t Nantes
Thanks for the test, I'll see about implementing this change soon.
Regarding the prerequisite to +10.3.0, this is related to the dependency on the "Single Directory Components" module (sdc) which became a placeholder from 10.3.0 and which will no longer exist in Drupal 11.
We could therefore not keep this prerequisite when activating the theme.
Rather than having several Git branches to maintain for this single constraint, we decided to encourage theme implementers to upgrade to Drupal >=10.3 to continue to benefit from fixes and developments.You can use the Leniant Composer plugin → if tomorrow you are blocked by this constraint.
- a601a644 committed on 1.x
Issue #3494692: Use "base_path()" instad of static "/".
- a601a644 committed on 1.x
- 🇫🇷France S3b0uN3t Nantes