- Issue created by @jurgenhaas
- πΊπΈUnited States phenaproxima Massachusetts
Yes and yes. I would gladly merge this.
- π©πͺGermany jurgenhaas Gottmadingen
OK, I'll create the MR as soon as π Privacy policy link goes to a 403 Active has landed. Otherwise, we may run into strange issues.
- π©πͺGermany jurgenhaas Gottmadingen
Now that the related issue got merged, I get started on this one.
And the good news on top: ECA 2.1.0 has just been released, as well as BPMN.io - so I can bump their constraints across Drupal CMS at the same time as well.
- Merge request !328Issue #3494246: Add versions to ECA models, and remove their XML files β (Merged) created by jurgenhaas
- πΊπΈUnited States phenaproxima Massachusetts
Idea: while we're at it, let's update our top level
.gitignore
rules to exclude anyeca.model.*.yml
files. That way we don't accidentally commit more of them! - πΊπΈUnited States phenaproxima Massachusetts
And a question: if we are removing the models, does this mean we can also remove bpmn_io from our dependencies (although we should keep it as a dev dependency in
dev.composer.json
)? - π©πͺGermany jurgenhaas Gottmadingen
Adding
eca.model.*.yml
to.gitignore
makes sense.But bpmn_io should be kept for end users. @pameeela was keen to have this available for end users so that we don't keep the fancy features in the dark but expose them to the site builder.
What we've implemented in the bpmn_io modeller is the so-called upstream conversion. So, without having the proprietary XML data available, we're now able to re-create that from downstream. So, the ECA models are still editable with BPMN.io without any further action required by the user.
This MR is now ready for review.
- πΊπΈUnited States phenaproxima Massachusetts
Gotcha. We're eventually planning to have a drupal_cms_dev_tools recipe, which would enable advanced stuff like Views UI. That'd be a great place to also depend on, and enable, BPMN.io. But that recipe doesn't exist yet, and won't until after 1.0.
-
phenaproxima β
committed 088dddf1 on 1.x authored by
jurgenhaas β
Issue #3494246 by jurgenhaas: Add versions to ECA models, and remove...
-
phenaproxima β
committed 088dddf1 on 1.x authored by
jurgenhaas β
- πΊπΈUnited States phenaproxima Massachusetts
Great clean-up! No more inscrutable walls of XML here. Merged with glee into 1.x. Thanks!
- πΊπΈUnited States phenaproxima Massachusetts
Crediting @lammenjs on @jurgenhaas' blessing. From Slack:
credit goes to @Jasper Lammens who implemented that upstream conversion. His use case is even more exciting: he lets AI create ECA models, which works to create the pure ECA model in YML. But if you want to edit that AI output, you need to have the BPMN data, and that's what he implemented. I'm thrilled about that
-
phenaproxima β
committed aeb8be70 on 1.0.x authored by
jurgenhaas β
Issue #3494246 by jurgenhaas: Add versions to ECA models, and remove...
-
phenaproxima β
committed aeb8be70 on 1.0.x authored by
jurgenhaas β