- Issue created by @kazajhodo
- 🇺🇸United States kazajhodo
I've pushed my fix into the fork.
Then I'm going to use a patch to resolve this locally for the time being, so here is that should anyone find it useful.
Oh my god....why in the f@ck is a Google Tag module involved in discount calculations and adjustments?
This issue has nothing to do with the placement of the Google Tag Manager script. Is the goal create a version of Quickbooks?
This is a prime example of mission creep. Over time, functionality is built up to please users, but that functionality comes with a lifetime service commitment, and that's usually not clear at in the beginning.
The user is probably delighted they got some free engineering resources to help with a personal problem.
Meanwhile, the Module doesn't work correctly....
- 🇺🇸United States kazajhodo
@westlinnsamething
The module is just grabbing data and setting keys/values, regarding an assumed base requirement of a purchase event. There are assumptions regarding generally what the broad user case would want those values to be.
In this case passing:
- currency
- value
- transaction_id
- shipping
- tax
- items
Then for item data:
- item_id
- item_name
- affiliation
- discount
- price
- quantity
In my case, for tax, the number was not what they expected. On review, it seems to me that a client would in most cases, if not all, expect the data as I've adjusted it; and be more-than-likely confused in all other circumstances.
It doesn't have to change of course, I'm just bringing it up incase it should.