Contrib.social

Error when uploading files in D10.2+ due to file validations

Open on Drupal.org →
Created on 12 December 2024, 7 months ago

Problem/Motivation

When editing files with this module in D10.2+, the following error message would result:

TypeError: Drupal\file\Upload\FileUploadHandler::handleExtensionValidation(): Return value must be of type string, null returned in Drupal\file\Upload\FileUploadHandler->handleExtensionValidation() (line 431 of core/modules/file/src/Upload/FileUploadHandler.php).}}

This is related to the matters discussed here: https://www.drupal.org/project/drupal/issues/3420802 🐛 file_save_upload broken by 10.2.x Needs work as the variable names have been updated in newer versions of Drupal. This patch may also resolve some of the TODOs in FileManagementEditFileForm.php

Steps to reproduce

Default installation in D10.2+ (Hasn't been tested in D11)

Proposed resolution

A minor patch to update to update the logic of FileManagementEditFileForm.php to make it more compatible with D10.2+. This has not been tested in D11. Please note that this patch by default has a certain subset of file types coded in for validation purposes.

🐛 Bug report
Status

Downport

Version

2.1

Component

Code

Created by

🇺🇸United States nycnuac

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @nycnuac
  • Comment 7 months ago →
    🇺🇸United States nycnuac
  • Comment 7 months ago →
    🇺🇸United States nycnuac
  • Comment 7 months ago →
    🇺🇸United States nycnuac
  • Status changed to Needs review about 1 month ago
  • Comment about 1 month ago →
    🇪🇸Spain javilagos Zaragoza

    Hello, I applied #4 to my Drupal 10.3 environment and, while it works, the available extensions for the newly uploaded file are hardcoded to be mainly for text files. This means that, if you come from an image file (e.g. a .jpeg), you could only upload a .txt, .pdf... with said patch. A proposed solution would be to allow any extension as per the base module intentions, changing
    $new_file = file_save_upload('new_file', ['FileExtension' => []]);
    Or check the file type to modify and limit the formats to the file type (which is not the base functionality but seems more desirable).

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024