- Issue created by @jacobupal
- 2dc4a057 committed on 1.0.x
Issue #3493579: Load contextual balloon as dependency
- 2dc4a057 committed on 1.0.x
- 🇫🇷France lazzyvn paris
test on drupal 10 11 but I can't reproduce the error message.
I add this method in dev version anyway - 🇬🇧United Kingdom jacobupal Leeds
I just tried this again. This time with a clean install of Drupal 10.0.4 using drupalpod, with ckeditor_insert_blocks 1.0.0.
To reproduce the error, (and demonstrate the fix) this is exactly what I did:
1. Install Drupal 10.0.4 using drupalpod, with ckeditor_insert_blocks 1.0.0.
Make sure the fix for this issue hasn't accidentally been included already (I had to manually remove it, because drupalpod installs version1.x-dev by default, and in that branch the recommended code has already been added)
To ensure the right version is being tested, this should not appear in the code when testing:
static get requires() { return [ContextualBalloon]; }
1. Make a new text-format - The preconfigured text-formats (html, full_html, etc) will not trigger the error because they have some other plugins enabled by default - You will need to create a new text format where you will see that only "bold" "italic" and "Headings" are enabled, but no other buttons, or filters.
2. Add the ckeditor_insert_blocks button and filter.
3. Edit a piece of content with this new text format.
4. The toolbar will not load.
5. Add the following to the code:
static get requires() { return [ContextualBalloon]; }
6. Refresh and you will see it works again.
I've attached a video showing the change which occurs with or without the additional code.
So I think we can call this "Fixed".
- 🇫🇷France lazzyvn paris
Did you try the dev version to see if it works?
and have you tried the block content type, does it work when you update? - 🇬🇧United Kingdom jacobupal Leeds
I did try the dev version, it works correctly, as shown.
I will try in the content blocks now... yep it works exactly the same way as it does for content types!
Automatically closed - issue fixed for 2 weeks with no activity.