String "0" not printed as suggestion suffix

drunken monkey → made their first commit to this issue’s fork.

Great catch, thanks a lot for reporting this and already providing an MR.
Based on a quick test, I think all of those should actually be checked with … is not empty, it seems like '0' (or 0) would be a valid value for all of those (though more likely for some than for others).
I amended the MR. Please test/review!

*bump* Please test/review so I can merge this.

@drunkenmonkey: Sorry, missed the hint about test and review.

I can confirm that it works for me as expected now with the patch, though I am probably only really testing the suffix/prefix part.

Regarding the other variables, I do not have a case to test on.

In principle, I think the "not empty" check is preventing ambiguousness and should be favored. Only with the result count I am in doubt if a value of "0" should be considered empty or is expected to be empty? But is it possible at all to have a result count "0" and appear in the autocomplete suggetions at all?

In principle, I think the "not empty" check is preventing ambiguousness and should be favored. Only with the result count I am in doubt if a value of "0" should be considered empty or is expected to be empty? But is it possible at all to have a result count "0" and appear in the autocomplete suggetions at all?

It’s admittedly unlikely, but since the value can be NULL it should be assumed that 0 represents a valid count that should be reported, I think. If anything, I’d just stick with this for the sake of consistency.

I merged the MR now. Thanks a lot again!

Automatically closed - issue fixed for 2 weeks with no activity.