"Temporarily Dismissible" should not include a cookie confirmation

Created on 11 December 2024, 4 months ago

Problem/Motivation

I'm finding that even when I set my block to "Block is temporarily dismissable" it still triggers the to popup.

DismissableBlockHelperService.php seems to apply "dismissableblocks-remember" to all dismissable blocks. And there is an "if type == cookie" commented out, presumably from a previous iteration that distinguished between both options.

Steps to reproduce

- Make a block dismissable
- Set the type to "Block is temporarily dismissable"
- Try to dismiss the block
- The dialog still appears

Proposed resolution

- Modify src/Service/DismissableBlockHelperService.php to apply a dismissableblocks-remember class to temporarily dismissable blocks.
- Make a js/dismissable_temporary.js which targets the dismissableblocks-temporary class
- Change js/dismissable_and_remember.js to target only the dismissableblocks-remember class

Remaining tasks

- Make an MR
- Review
- Merge

User interface changes

No more dialog box on temporarily dismissable blocks

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom jacobupal Leeds

Live updates comments and jobs are added and updated live.

Merge Requests

!2"Temporarily Dismissible" should not include a cookie confirmation
Merged
🇬🇧United Kingdom jacobupal
updated 4 months ago

Comments & Activities

Issue created by @jacobupal
Merge request !2Provide temporarily dismissable blocks without the dialog modal. → (Merged) created by jacobupal
Comment 4 months ago →
🇬🇧United Kingdom jacobupal Leeds
Comment 4 months ago →
🇺🇸United States mlncn Minneapolis, MN, USA
Wow, thank you! I guess i forgot to implement this more straightforward option entirely.

Merged this in, hope more people can review the branch and will make a release soon.

Uh, in case i forget, @jacobupal are you interested in being a co-maintainer?

Thanks!
Comment 4 months ago →
🇬🇧United Kingdom jacobupal Leeds
Ooh thanks for approving, and sure that'd be great!
Comment 4 months ago →
🇬🇧United Kingdom jacobupal Leeds
Comment 4 months ago →
🇬🇧United Kingdom jacobupal Leeds

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024