phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .
FILE: .../web/modules/custom/quiz_maker/config/optional/addtoany.settings.yml
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
24 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
15 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
17 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
27 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
29 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
39 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/css/quiz_timer.css
-----------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 6 LINES
-----------------------------------------------------------------------------------
40 | ERROR | [ ] Style definition is empty
40 | ERROR | [x] Expected 1 space after colon in style definition; newline found
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [ ] No style definition found on line; check for missing colon
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [ ] No style definition found on line; check for missing colon
59 | ERROR | [ ] Style definition is empty
59 | ERROR | [x] Expected 1 space after colon in style definition; newline found
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
60 | ERROR | [ ] No style definition found on line; check for missing colon
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [ ] No style definition found on line; check for missing colon
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/css/quiz_maker.css
-----------------------------------------------------------------------------------
FOUND 50 ERRORS AFFECTING 33 LINES
-----------------------------------------------------------------------------------
222 | ERROR | [x] Selectors must be on a single line
223 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
223 | ERROR | [x] Selectors must be on a single line
224 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
224 | ERROR | [x] Selectors must be on a single line
225 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
241 | ERROR | [x] Selectors must be on a single line
242 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
242 | ERROR | [x] Selectors must be on a single line
243 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
243 | ERROR | [x] Selectors must be on a single line
244 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
248 | ERROR | [x] Selectors must be on a single line
249 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
249 | ERROR | [x] Selectors must be on a single line
250 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
250 | ERROR | [x] Selectors must be on a single line
251 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
261 | ERROR | [x] Selectors must be on a single line
262 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
262 | ERROR | [x] Selectors must be on a single line
263 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
263 | ERROR | [x] Selectors must be on a single line
264 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
264 | ERROR | [x] Selectors must be on a single line
265 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
270 | ERROR | [x] Selectors must be on a single line
271 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
271 | ERROR | [x] Selectors must be on a single line
272 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
272 | ERROR | [x] Selectors must be on a single line
273 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
279 | ERROR | [x] Selectors must be on a single line
280 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
280 | ERROR | [x] Selectors must be on a single line
281 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
281 | ERROR | [x] Selectors must be on a single line
282 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
283 | ERROR | [x] Selectors must be on a single line
284 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
284 | ERROR | [x] Selectors must be on a single line
285 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
285 | ERROR | [x] Selectors must be on a single line
286 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
290 | ERROR | [x] Selectors must be on a single line
291 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
291 | ERROR | [x] Selectors must be on a single line
292 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
292 | ERROR | [x] Selectors must be on a single line
293 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 50 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Entity/QuestionAnswer.php
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
220 | ERROR | [x] Parameter $response has null default value, but is not marked as nullable.
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Entity/Question.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
352 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Entity/QuestionResponse.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
281 | ERROR | [x] Parameter $score has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Form/QuizTakeForm.php
------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
89 | ERROR | [x] Parameter $quiz has null default value, but is not marked as nullable.
261 | ERROR | [x] Parameter $quiz has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Form/QuizResultReviewForm.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
74 | ERROR | [x] Parameter $quiz_result has null default value, but is not marked as nullable.
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/QuestionResponseInterface.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
109 | ERROR | [x] Parameter $score has null default value, but is not marked as nullable.
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/QuestionAnswerInterface.php
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
35 | ERROR | [x] Parameter $response has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Service/QuizResultManager.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
71 | ERROR | [x] Parameter $session_id has null default value, but is not marked as nullable.
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Service/QuizHelper.php
------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------
64 | ERROR | [x] Parameter $list_style has null default value, but is not marked as nullable.
122 | ERROR | [x] Parameter $style has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/QuestionAnswerPluginBase.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
83 | ERROR | [x] Parameter $response has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Question/MultipleChoiceQuestion.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
29 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Question/MatchingQuestion.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
29 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Question/SingleChoiceQuestion.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Question/DirectQuestion.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Question/BooleanQuestion.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Answer/MatchingAnswer.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
73 | ERROR | [x] Parameter $response has null default value, but is not marked as nullable.
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/Answer/DirectAnswer.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
25 | ERROR | [x] Parameter $response has null default value, but is not marked as nullable.
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Plugin/QuizMaker/QuestionResponsePluginBase.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
88 | ERROR | [x] Parameter $score has null default value, but is not marked as nullable.
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/Trait/SimpleScoringResponseTrait.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
19 | ERROR | [x] Parameter $score has null default value, but is not marked as nullable.
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
FILE: .../web/modules/custom/quiz_maker/src/QuestionInterface.php
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
51 | ERROR | [x] Parameter $question_response has null default value, but is not marked as nullable.
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .
Active
1.0
Code
Hi @alyaj2a
I reviewed your MR, no errors were found using the phpcs command in Issue summary.
Also, the phpcs pipeline is green.
Moving it to RTBC
Great work
Hi, thanks for the work, I missed your PR and code style issues were fixed here - https://git.drupalcode.org/project/quiz_maker/-/commit/f38d60107207f52e1... , anyway good job! Thanks!