- Issue created by @poker10
- Merge request !637Issue #3492153 : Hide project icon for modules with 0 usage → (Merged) created by shalini_jha
- 🇮🇳India shalini_jha
I included the project icon in the existing condition to ensure it is displayed only when the module usage is not zero. This hides the project icon when the module usage is zero. However, the pipeline is failing with an ESLint error. Even after reverting the code, the ESLint failure persists, suggesting that the issue might not be related to this specific code change. I am unsure about the root cause of the failure and am moving this to NR to seek guidance on resolving the pipeline issue.
- 🇮🇳India shalini_jha
Re based & fixed merge conflicts Also Tweak logic for hiding the icon.
- First commit to issue fork.
- 🇺🇸United States chrisfromredfin Portland, Maine
I've rebased to latest and then manually tested. It seems now though that the icon is gone on the Grid view.
- 🇮🇳India shalini_jha
I previously reviewed this and confirmed that the "usage icon" is not included in the grid view; it is only present in the list view.
I have double-checked this to ensure accuracy, and I can confirm that this behaviour is same. The icon is display only in the list view and not in the grid view.
I’m moving this for review again. Please let me know if I’ve missed anything. - First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
This worked nicely.
First thing I did was hack the Recipes source to set all the recipes to have 0 usage count. In 2.0.x, that resulted in the following:
And with the fix:
That's a straight RTBC.
-
chrisfromredfin →
committed cd18c9b8 on 2.0.x authored by
shalini_jha →
Issue #3492153 by shalini_jha, chrisfromredfin, phenaproxima, poker10:...
-
chrisfromredfin →
committed cd18c9b8 on 2.0.x authored by
shalini_jha →
Automatically closed - issue fixed for 2 weeks with no activity.