Project usage icon is shown on List view even if a project does not have any usage

Created on 6 December 2024, 4 months ago

Problem/Motivation

When you open project browser (/admin/modules/browse) and switch to List view, you can see that modules without any usage (i.e. 0) still shows the Project usage icon. The icon is not shown on a Grid view (in case the usage is 0), so I suppose this is not a feature.

Steps to reproduce

Open /admin/modules/browse
Switch to List view
Find a project with 0 usage and observe that Project usage icon is still shown without any visible text

Proposed resolution

Hide the icon as on the Grid view

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇸🇰Slovakia poker10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @poker10
  • 🇮🇳India shalini_jha

    I am able to replicate this issue , working on it.

  • Pipeline finished with Failed
    4 months ago
    Total: 4432s
    #361022
  • Pipeline finished with Failed
    4 months ago
    Total: 425s
    #361092
  • Pipeline finished with Failed
    4 months ago
    Total: 367s
    #361104
  • 🇮🇳India shalini_jha

    I included the project icon in the existing condition to ensure it is displayed only when the module usage is not zero. This hides the project icon when the module usage is zero. However, the pipeline is failing with an ESLint error. Even after reverting the code, the ESLint failure persists, suggesting that the issue might not be related to this specific code change. I am unsure about the root cause of the failure and am moving this to NR to seek guidance on resolving the pipeline issue.

  • Pipeline finished with Failed
    4 months ago
    Total: 419s
    #361109
  • 🇮🇳India shalini_jha

    Re based & fixed merge conflicts.

  • Pipeline finished with Failed
    4 months ago
    Total: 511s
    #365379
  • 🇮🇳India shalini_jha

    Re based & fixed merge conflicts Also Tweak logic for hiding the icon.

  • Pipeline finished with Failed
    4 months ago
    Total: 594s
    #365400
  • Pipeline finished with Success
    4 months ago
    Total: 508s
    #367514
  • First commit to issue fork.
  • 🇺🇸United States chrisfromredfin Portland, Maine

    I've rebased to latest and then manually tested. It seems now though that the icon is gone on the Grid view.

  • Pipeline finished with Failed
    3 months ago
    Total: 394s
    #387797
  • 🇮🇳India shalini_jha

    I previously reviewed this and confirmed that the "usage icon" is not included in the grid view; it is only present in the list view.
    I have double-checked this to ensure accuracy, and I can confirm that this behaviour is same. The icon is display only in the list view and not in the grid view.
    I’m moving this for review again. Please let me know if I’ve missed anything.

  • 🇮🇳India shalini_jha

    Re base and fixed conflicts.

  • Pipeline finished with Failed
    3 months ago
    Total: 478s
    #389708
  • First commit to issue fork.
  • Pipeline finished with Success
    3 months ago
    Total: 448s
    #389935
  • 🇺🇸United States phenaproxima Massachusetts

    This worked nicely.

    First thing I did was hack the Recipes source to set all the recipes to have 0 usage count. In 2.0.x, that resulted in the following:

    And with the fix:

    That's a straight RTBC.

  • Pipeline finished with Success
    3 months ago
    Total: 437s
    #390177
  • Pipeline finished with Skipped
    3 months ago
    #390180
  • 🇺🇸United States chrisfromredfin Portland, Maine

    made it!

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    2 months ago
    Total: 694s
    #420886
  • Pipeline finished with Success
    2 months ago
    Total: 1216s
    #420901
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1862s
    #427169
  • Pipeline finished with Success
    about 2 months ago
    Total: 1574s
    #427207
  • Pipeline finished with Failed
    about 2 months ago
    Total: 641s
    #432921
  • Pipeline finished with Failed
    about 2 months ago
    Total: 624s
    #432926
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1178s
    #432928
  • Pipeline finished with Failed
    about 2 months ago
    Total: 635s
    #433789
  • Pipeline finished with Success
    about 2 months ago
    Total: 1361s
    #433800
  • Pipeline finished with Success
    3 days ago
    Total: 1690s
    #470084
Production build 0.71.5 2024