_Some_ images not shown on drupal.org issues when posted in gitlab comments

Relevant code added in https://git.drupalcode.org/project/drupalorg/-/commit/b529b589904e2c8127...

Need to debug if it's still going inside that "if".

I'm not sure if something has changed in the way that GitLab returns the image markup / src attribute, it might be that.

Adding something like this (you can copy/paste it on the issue) fixes the issue:

for (let image of document.querySelectorAll('img.lazy')) {
  image.setAttribute('src', image.dataset.src);
}

I'll do an MR based on this.

I think that the code is expecting this URL: https://git.drupalcode.org/-/project/dashboard/uploads/dd7a71233e84b4308...

But it's receiving this: https://git.drupalcode.org/-/project/552/uploads/dd7a71233e84b430861886d...

So it cannot parse the project name.

The MR contains the suggested code.

You can test it copy/pasting this in the mentioned issue in the developer tools:

for (let image of document.querySelectorAll('img.lazy')) {
  const match = image.dataset.src.match(/^\/(?<projectPath>.+)\/uploads\/[0-9a-f]+\/[^\/]*$/);
  if (match !== null && match.groups.projectPath === projectPath) {
    image.setAttribute('loading', 'lazy');
    image.setAttribute('src', Drupal.settings.drupalorgGitlabUrl + match[0]);
  }
  else if (image.dataset.src.startsWith(Drupal.settings.drupalorgGitlabUrl)) {
    image.setAttribute('loading', 'lazy');
    image.setAttribute('src', image.dataset.src);
  }
}

Works for me on the console, and code-wise looks clean! Thanks!

Looks good, and I don’t see a risk of embedding arbitrary images. Deployed!