Contrib.social

Cache collision when multiple servers are using the same schema plugin

Open on Drupal.org →
Created on 4 December 2024, 4 months ago

Problem/Motivation

This is a continuation of the GitHub issue #1223: Two servers using the same schema, configured differently - only one works.

When multiple servers are using the same schema plugin, they all end up serving the same schema. This happens because the schema is cached using only the schema plugin name as a cache key, disregarding the fact that multiple servers might exist with different configuration.

Steps to reproduce

  1. Create 2 servers using the same schema (e.g. "Composable schema")
  2. Enable different extensions for the two servers.
  3. Fire up the GraphQL Explorer for both servers.

Expected result: each server should serve a different schema which matches the extensions configured for it.
Actual result: the same schema is served for both servers.

Proposed resolution

There is an existing PR (https://github.com/drupal-graphql/graphql/pull/1224) which introduces a new setServerId() method on the SdlSchemaPluginBase base class, but it is not good DX to force calling code to invoke a setter after instantiating a plugin.

A good solution could be to pass the server name in the plugin configuration when the plugin is instantiated. For backwards compatibility we could emit a deprecation warning if this is missing, and enforce it in a future 5.x release.

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024