Cleanup TfaUserDataTrait phpstan warnings

Created on 4 December 2024, 4 months ago

Problem/Motivation

The TfaUserDataTrait is used in many classes.

It has a number of phpstan warnings that fill the baseline, increase merge conflicts, and make it harder to maintain the code as any new calls is likely to add another warning.

Steps to reproduce

echo '' >phptan-baseline.neon
phpstan analyze ./

Proposed resolution

Resolve coding standard issues in trait and update baseline.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States cmlara

Live updates comments and jobs are added and updated live.

Merge Requests

!102Cleanup TfaUserDataTrait phpstan warnings
Merged
🇺🇸United States cmlara
updated 4 months ago
!101Cleanup TfaUserDataTrait phpstan warnings
Merged
🇺🇸United States cmlara
updated 4 months ago

Comments & Activities

Issue created by @cmlara
Merge request !101Issue #3491476: Cleanup TfaUserDataTrait phpstan warnings → (Merged) created by cmlara
Merge request !102Issue #3491476: Cleanup TfaUserDataTrait phpstan warnings → (Merged) created by cmlara
Comment 4 months ago →
System Message

cmlara → committed 6aa1338e on 2.x
Issue #3491476: Cleanup TfaUserDataTrait phpstan warnings
Comment 4 months ago →
System Message

cmlara → committed e298fbf1 on 8.x-1.x
Issue #3491476: Cleanup TfaUserDataTrait phpstan warnings
Comment 4 months ago →
🇺🇸United States cmlara
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024