Error when saving Key, but still saved

Created on 3 December 2024, 4 months ago

Problem/Motivation

I have not tested this with the dev release of https://www.drupal.org/project/key β†’ yet, but I think the fact that the Value is NULL when using a Pantheon Secret with the 1.19 release of Key results in...

TypeError: Drupal\Core\Entity\EntityStorageBase::getEntityClass(): Return value must be of type string, null returned in Drupal\Core\Entity\EntityStorageBase->getEntityClass() (line 115 of /code/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php).

The Key is still saved and appears to work, but this error is less than ideal.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States kreynen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kreynen
  • πŸ‡ΊπŸ‡ΈUnited States kreynen
  • πŸ‡ΊπŸ‡ΈUnited States kreynen

    Hello? Is there anyone from Pantehon here?

    I brought up the fact that no one from Pantheon responds to the issues in the open source aspects of you services the Partner Roadmap meeting last month... and was told to bring this up with our sales rep. So I guess that's what I'll do next.

  • πŸ‡¨πŸ‡·Costa Rica kporras07

    Hi @kreynen,

    I looked into this and the only way I was able to reproduce it was when I tried to add a key with a machine name that already exists.

    I kept looking into this and noticed that this doesn't happen exclusively with pantheon_secrets but (I think) with any provider plugin that doesn't input a value. For example I was able to reproduce it with environment provider.

    I think this is most likely to be an issue with Key but I haven't had the time to pinpoint the exact issue but with these findings I'm pretty sure this is not a pantheon_secrets thing.

    If you have any additional information or steps to reproduce that could help point in the direction of an actual pantheon_secrets bug that would be super helpful.

    Thanks!

Production build 0.71.5 2024