- Issue created by @nicxvan
- π¬π§United Kingdom catch
Oof that was my suggestion in the other issue. Feels like it should be possible to make this work - if we only have OOP hooks, we should only have to scan the hooks directory, but probably means two complete logic branches not this quick (broken) fix.
Moving to RTBC, since this is a critical regression from the previous issue, I'll commit it later if no objections.
- πΊπΈUnited States nicxvan
Yes, we could make that work, but it definitely needs a follow up, we currently look at every single file in a module directory.
We could probably safely limit it to scan just the top level and /src/Hooks always whether you do procedural or not. That will reduce the number of iterations significantly too.
- πΊπΈUnited States nicxvan
π Limit iterator in HookCollectorPass Active
- π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.