Contrib.social

Payment Gateway is not usable as an exposed filter in Views Orders list

Open on Drupal.org →
Created on 3 December 2024, 19 days ago

Problem/Motivation

  • Payment Gateway exposed filter is plain text rather than a dropdown.
  • It expects a machine name like 'purchase_order_gateway' in a plain text filter, but the table rows show the label like 'Purchase Orders'.
  • This makes it usuable by developers (after they dig) but not usable by content editors without detailed instructions

Steps to reproduce

  1. Install Commerce & Payment
  2. Set up more than 1 payment gateway
  3. Edit /admin/commerce/orders Views to add Payment Gateway as an exposed filter
  4. Go to Orders list
  5. Attempt to use the exposed filter

Proposed resolution

Views filter plugin extending InOperator to make a dropdown

Remaining tasks

MR

User interface changes

Payment Gateway available as an exposed filter dropdown

API changes

N/A

Data model changes

N/A

Release notes

Payment Gateway Views filters now extend the In Operator Views Filter, meaning existing filters using options like regular expressions should be manually updated to use the select list. If your Admin > Commerce > Orders list is unchanged from the default installation, this does not affect you. If you do not allow editors to filter by Payment Gateway (like the default), this does not affect you.

✨ Feature request
Status

Active

Version

3.0

Component

Payment

Created by

🇬🇧United Kingdom scott_euser

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @scott_euser
  • Merge request !380Resolve #3491311 "Payment gateway views filter" → (Open) created by scott_euser
  • Pipeline finished with Success
    19 days ago
    Total: 1625s
    #357586
  • Comment 19 days ago →
    🇬🇧United Kingdom scott_euser

    Screenshot of updated payment gateway exposed filter:

    I couldn't see if there is automated test coverage for the existing Views Filter plugin for entity bundles. Ignoring that, do you want test coverage for this, if so, test sub-module within commerce_payment preferred? (since this relies on the Payment sub-module).

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024