- Issue created by @dharizza
- π¨π·Costa Rica dharizza
This is a Drupal CMS stable blocker. See #3487542-13: Add Google Tag recipe.
- πΊπΈUnited States phenaproxima Massachusetts
OK, that code looks good to me.
It is worth noting that the test failures are entirely originating from commerce_price, which seems to have a big pile of incompatibilities. (Presumably it's a dev dependency.) Because trying to fix that is very out of scope, and it is urgent for us to land this in order for Drupal CMS to be released on time, I am hoping the maintainers will commit this patch and tag a new release anyway if they agree that it is not likely to disrupt anything and that the CI failures are unrelated.
- πΊπΈUnited States mglaman WI, USA
There's a reason we needed it to be in the header. Unfortunately I can't recall why. I'll look.
- π¨π·Costa Rica dharizza
This was introduced by https://www.drupal.org/project/google_tag/issues/3452712 π Possibly script loading/placement issue Fixed , but when I was testing it didn't look like I needed to have the gtag.ajax in the header as well, just gtag and gtm makes it for me, so that's why I only moved the ajax one.
- πΊπΈUnited States mglaman WI, USA
Here's where/why it was added: π Possibly script loading/placement issue Fixed
- πΊπΈUnited States phenaproxima Massachusetts
If it changes anything, the library being changed is
gtag.ajax
, which only hooks into core AJAX system. As far as I know, there's no particular reason that core AJAX stuff needs to be in the header...? Can't speak to thegtm
andgtag
libraries on that count, but they are not affected by this patch. - πΊπΈUnited States mglaman WI, USA
Per #3452712-16: Possibly script loading/placement issue β and the reference core issue, this should fix some problems. We need the main library in the header. But AJAX should be okay without that toggle.
-
mglaman β
committed a150713b on 2.0.x authored by
dharizza β
Issue #3491175: Loading the library gtag.ajax in the header causes...
-
mglaman β
committed a150713b on 2.0.x authored by
dharizza β
- πΊπΈUnited States mglaman WI, USA
Automatically closed - issue fixed for 2 weeks with no activity.