Installer: Language selector button shows during install progress, but no languages in the dropdown

Created on 28 November 2024, 4 months ago

Installer: Language selector button shows during install progress, but no languages in the dropdown.

πŸ› Bug report
Status

Active

Component

Track: Installer

Created by

πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mherchel
  • Pipeline finished with Canceled
    4 months ago
    Total: 64s
    #353463
  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Can you flesh out the issue summary a tad? πŸ™ What's the solution here?

  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US
  • Pipeline finished with Failed
    4 months ago
    Total: 811s
    #353470
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I actually am wondering if we should ever show the "select language" button during the progress bar. If we did show it, and someone tried to switch languages in the middle of the install process, I'm not sure that would work - it might just break the install process outright.

  • Pipeline finished with Success
    4 months ago
    Total: 1238s
    #353467
  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US

    The MR code hides the select language button on during the progress stage because drupalSettings.languages is not available at that point, FYI.

  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Yeah, that makes sense; but I'm wondering if it makes sense to take even stronger steps and prevent the possibility that it will ever show up on that page. What do you think? Is that easy to do? It would be my preference if so.

  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US

    Is that easy to do?

    I looked when I was originally doing it, and I didn't see any CSS class on any wrapper element that's specific to the progress stage that I could use. If we add one, we could easily do that.

    Without looking deeper, I'm not sure how difficult it is to add that CSS class though. If you want, I can dig deeper.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    We could do it with a CSS class but is there a way we could just wholesale remove the element from page? (A template we could alter?)

  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US

    A template we could alter?

    Everything is within project_template/web/profiles/drupal_cms_installer/templates/install-page.html.twig. I don't see any variables that indicate the current page. Once again, I can play around a bit (maybe in preprocess or something) to see if there's anything that would indicate the current state. If you have any ideas or whatever let me know.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Quick manual test and wouldaj look at that: no language selector on the progress page! The solution here is good enough for me, I think, having done the due diligence of asking @mherchel a bunch of annoying questions.

  • Pipeline finished with Skipped
    4 months ago
    #354518
  • Pipeline finished with Skipped
    4 months ago
    #354520
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Whoo! Gleefully merged into 0.x. Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024