- Issue created by @mherchel
- Merge request !249Check for languages before setting up language dropdown. β (Merged) created by mherchel
- πΊπΈUnited States phenaproxima Massachusetts
Can you flesh out the issue summary a tad? π What's the solution here?
- πΊπΈUnited States phenaproxima Massachusetts
I actually am wondering if we should ever show the "select language" button during the progress bar. If we did show it, and someone tried to switch languages in the middle of the install process, I'm not sure that would work - it might just break the install process outright.
- πΊπΈUnited States mherchel Gainesville, FL, US
The MR code hides the select language button on during the progress stage because drupalSettings.languages is not available at that point, FYI.
- πΊπΈUnited States phenaproxima Massachusetts
Yeah, that makes sense; but I'm wondering if it makes sense to take even stronger steps and prevent the possibility that it will ever show up on that page. What do you think? Is that easy to do? It would be my preference if so.
- πΊπΈUnited States mherchel Gainesville, FL, US
Is that easy to do?
I looked when I was originally doing it, and I didn't see any CSS class on any wrapper element that's specific to the progress stage that I could use. If we add one, we could easily do that.
Without looking deeper, I'm not sure how difficult it is to add that CSS class though. If you want, I can dig deeper.
- πΊπΈUnited States phenaproxima Massachusetts
We could do it with a CSS class but is there a way we could just wholesale remove the element from page? (A template we could alter?)
- πΊπΈUnited States mherchel Gainesville, FL, US
A template we could alter?
Everything is within
project_template/web/profiles/drupal_cms_installer/templates/install-page.html.twig
. I don't see any variables that indicate the current page. Once again, I can play around a bit (maybe in preprocess or something) to see if there's anything that would indicate the current state. If you have any ideas or whatever let me know. - πΊπΈUnited States phenaproxima Massachusetts
Quick manual test and wouldaj look at that: no language selector on the progress page! The solution here is good enough for me, I think, having done the due diligence of asking @mherchel a bunch of annoying questions.
-
phenaproxima β
committed 16ed2b30 on 0.x authored by
mherchel β
Issue #3490523 by mherchel: Installer: Language selector button shows...
-
phenaproxima β
committed 16ed2b30 on 0.x authored by
mherchel β
- πΊπΈUnited States phenaproxima Massachusetts
Whoo! Gleefully merged into 0.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.