Dynamic property creation on bulk update fields form

Created on 25 November 2024, 24 days ago

Problem/Motivation

Using Bulk Update Content Fields throws "Creation of dynamic property" deprecation error. This will eventually block compatibility with PHP 9

Steps to reproduce

Install the Action and Bulk Update Fields modules.

Create two or more pieces of content.
Visit the content listing.
Select two or more pieces of content.
Select the "Bulk update content fields" action and press "Apply to selected items".
See the following error message:

Deprecated function: Creation of dynamic property Drupal\bulk_update_fields\Form\BulkUpdateFieldsForm::$entity is deprecated in Drupal\bulk_update_fields\Form\BulkUpdateFieldsForm->buildForm() (line 219 of modules/contrib/bulk_update_fields/src/Form/BulkUpdateFieldsForm.php).
Drupal\bulk_update_fields\Form\BulkUpdateFieldsForm->buildForm()
call_user_func_array() (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 284)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Proposed resolution

Update the form to make sure $entity is declared.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States byrond

Live updates comments and jobs are added and updated live.

Merge Requests

!19Dynamic property creation on bulk update fields form
Open
🇺🇸United States byrond
updated 24 days ago

Comments & Activities

Issue created by @byrond
Merge request !193489631: Add entity property to BulkUpdateFieldsForm to prevent dynamic creation deprecation error → (Open) created by byrond
Comment 24 days ago →
🇺🇸United States byrond
I created an MR to add the property to the form, but it looks like it is never used outside of the buildForm() method. Could a local variable be used there instead, or does something else read this property elsewhere? It seems unlikely, because this property will only hold the last entity of the ones passed to the form.
Pipeline finished with Success
24 days ago
Total: 139s
#349521

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024