Maintenance message showing where a "note" is not specified.

Created on 23 November 2024, 2 months ago

Problem/Motivation

I manage a site which has a "Settings Profile" with the "Take site offline" box ticked and a site is currently being maintained message in the "Description" box. Having updated to version 5.1.0 of Backup and Migrate (Drupal core 10.3.10) running a "Quick Backup" with the "Add a note to the backup" box unchecked, I find that this maintenance message appears under the backup as shown on the "Saved Backups" page. Not only that, but all previous "Scheduled Backups" made using the same Settings Profile have also acquired this maintenance message. This was not the case when running B&M 5.0.3 and is, I presume, a consequence of #2846650: Bring back "Description / note" field to quick save tab (as in Drupal 7 release) . As this was intended to recreate the "note" feature found in Drupal 7, and as Drupal 7 does not exhibit this behaviour, I'm presuming this to be a bug.

Steps to reproduce

Install or update to Backup and Migrate 5.1.0, Drupal core 10.3.10
Create a "Settings Profile" with "Take site offline" box ticked and a message in the "Description" box
Run a "Quick backup"
Observe the entry for that backup on the "Saved Backups" page

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

5.1

Component

Code

Created by

🇬🇧United Kingdom stevewilson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @stevewilson
  • 🇮🇳India girish_lnweb

    Hi @stevewilson,

    I have resolved the issue you reported regarding the maintenance message being displayed in the "Saved Backups" section when the "Add a note to the backup" box is unchecked in Backup and Migrate 5.1.0 and provide the patch for the same.

    please review once.

    Thank you

  • 🇬🇧United Kingdom stevewilson

    Thanks for the patch @girish_lnweb.

    I can confirm that with your patch the Quick Backup is performing as expected:
      With "Add a note to the backup" ticked, the Note is added to the backup;
      With "Add a note to the backup" unticked, there is no text added to the backup.

    This, however, is only a partial fix, each fresh, Scheduled backup still shows the site offline description text.
    In my site a Scheduled Backup utilises the same Settings Profile as a Quick Backup.

  • 🇮🇳India girish_lnweb

    Hi @stevewilson,

    Thanks for testing the patch and confirming the fix

    I understand the issue with Scheduled Backups still showing the site offline description text. To address this, I have created a new patch that should resolve the problem for Scheduled Backups as well.

    Please test the attached patch and let me know if it works as expected. Your feedback would be greatly appreciated!

    Thank you

  • 🇬🇧United Kingdom stevewilson

    Thanks for the second patch, it does seem to have fixed the scheduled backup issue.
    With the patch applied, I note that scheduled backups made prior to applying the patch retain the site offline description text (I can live with that) - a new scheduled backup however is, as expected, free of the site offline description text.

    My observation, as a user, is that the two patches, taken together, fully resolve this issue.

    Thank you @girish_lnweb.

Production build 0.71.5 2024