Contrib.social

Replace Drupal container with a Symfony one, stored in opcache

Open on Drupal.org →
Created on 21 November 2024, about 1 month ago

Problem/Motivation

Although Drupal depends on symfony/dependency-injection, it barely uses it. Drupal maintains own container implementation. Besides a dependency container written from scratch it also contains a custom dumper for it. See #2497243: Replace Symfony container with a Drupal one, stored in cache → for historical reference.

This container implementation is compatible with the default Symfony
dependency injection container and similar to the Symfony ContainerBuilder
class, but optimized for speed.

Even though the container documentation claims to optimize for speed, I think it actually has worse performance than the native Symfony container. However, I don't have any benchmarks yet.

The are two primary performance issues with the current implementation.

  1. The container is cached in database, which implies opening DB connection and fetching rather big piece of data (up to 1 MB). Symfony offers a PhpDumper that can be used to store container in Opcache.
  2. Lots of unserialize() calls. Each service definition is serialized individually and the entire container is serialized as well.

Besides performance, there are other issues:

  1. Maintenance cost. We have to support self-made DI implementation.
  2. Features from Symfony DI are not available by default. See 🌱 Bring new features from Symfony 3/4/5/6 into our container Active .

Proposed resolution

Replace Drupal container with a Symfony one.

📌 Task
Status

Active

Version

11.0 🔥

Component

base system

Created by

🇷🇺Russia Chi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Chi
  • Comment about 1 month ago →
    🇷🇺Russia Chi

    implies opening DB connection

    Opening DB connection is rather expensive operation, especially in PostgreSQL. Even if the cache is managed through in memory backend (Redis/Memcache) Drupal will open DB connection as bootstrap container depends on Database service.

  • Comment about 1 month ago →
    🇬🇧United Kingdom catch

    The Symfony container is written to a PHP file, unless something has changed.

    We can't require write permissions to a PHP file in production.

    Modules being installed/uninstalled and affecting the container means we also can't require the container is compiled at build time.

    These are the two reasons we moved to keeping the container in the database in the first place and they both continue to be valid as far as I know. The original decision to use Symfony's container ignored both of these constraints and we've been dealing with that since.

  • Comment about 1 month ago →
    🇷🇺Russia Chi

    We can't require write permissions to a PHP file in production.

    For Twig files it was resolved in #2544932: Twig should not rely on loading php from shared file system → . Can it be done same way for containers?

    Anyway DB based container cache may still exist and used as fallback for sites that need container rebuild in non CLI SAPI. The point is to use more efficient solution by default.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024