PHP Attributes not shown for Plugin source code

<?php namespace Drupal\Core\Field\Plugin\Field\FieldFormatter; use Drupal\Core\Field\Attribute\FieldFormatter; use Drupal\Core\StringTranslation\TranslatableMarkup; /** * Plugin implementation of the 'number_integer' formatter. * * The 'Default' formatter is different for integer fields on the one hand, and * for decimal and float fields on the other hand, in order to be able to use * different settings. */ class IntegerFormatter extends NumericFormatterBase { /** * {@inheritdoc} */ public static function defaultSettings() { return [ 'thousand_separator' => '', 'prefix_suffix' => TRUE, ] + parent::defaultSettings(); }

<?php namespace Drupal\Core\Field\Plugin\Field\FieldFormatter; use Drupal\Core\Field\Attribute\FieldFormatter; use Drupal\Core\StringTranslation\TranslatableMarkup; /** * Plugin implementation of the 'number_integer' formatter. * * The 'Default' formatter is different for integer fields on the one hand, and * for decimal and float fields on the other hand, in order to be able to use * different settings. */ #[FieldFormatter( id: 'number_integer', label: new TranslatableMarkup('Default'), field_types: [ 'integer', ], )] class IntegerFormatter extends NumericFormatterBase { /** * {@inheritdoc} */ public static function defaultSettings() { return [ 'thousand_separator' => '', 'prefix_suffix' => TRUE, ] + parent::defaultSettings(); }

Comments & Activities

Issue created by @tr
Comment 5 months ago →
🇪🇸Spain fjgarlin
I'd call this a duplicate of the related issues, and these are probably the most important issues that we currently have with the transition to PHP attributes. I won't close it so that when the work is done we can check issue by issue that all possible cases are fixed.
Comment 5 months ago →
🇺🇸United States tr Cascadia
Yes I see now that this has been mentioned before. Sorry for the duplication.

So there are two things I would like to make sure get addressed:

The old "Plugin annotation" documentation paragraph should be replaced by a "Plugin attribute" documentation, on the page where the plugin class is documented.

The source code pages and links should show the complete source code. I don't really understand the motivation for how it's currently done, with parsed-then-reconstructed source code being shown, because that leads to many problems like the missing Attributes and the changes to indentation, among others. This is a bigger problem than just the missing Attribute, because the current way is subject to break every time something new (like Attributes) is introduced into Drupal. IMO it would be better to display the raw source, or the raw source filtered to add hyperlinks, rather than a parsed-and-reconstructed source that will have problems every time the Parser doesn't do the right thing.
Comment 5 months ago →
🇪🇸Spain fjgarlin
That's the thing, we need to parse and reconstruct so all the links can be populated correctly, otherwise showing the code with no links would be somewhat useless. That parsing and reconstructing is currently the "heart" of the API project. I'm sure that there are better ways to do the things, but for now, that part of the module is unlikely to change. We "just" need to add support for new features.