Don't use parent menu link if disabled

Created on 18 November 2024, about 1 month ago

Problem/Motivation

If a menu position rule is attached to a disabled menu link parent, it is still used.
This can be confusing to site builders. It also means users clicking the parent link will get an error page.

Steps to reproduce

Create a new menu position rule and select a menu link as its parent.
Disable the parent menu link.
The breadcrumb still uses the parent.

Proposed resolution

MenuPositionActiveTrail::getActiveLink() could check if the parent is enabled before using it.
However, I am not sure how caching would be handled if the parent is latter re-enabled.

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Merge request, Patch, or Commit
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024