- Issue created by @agoradesign
- Merge request !35Issue #3487718 by agoradesign: Introduce an event to modify the skipped... → (Open) created by agoradesign
- 🇮🇱Israel jsacksick
hm... this event is reallllly specific... I'd be more in favor of introducing a setting for that (maybe at the gateway level?) Problem is, this method doesn't have access to the gateway... Could be just a setting that we fetch via Settings::get(), we'd just need to document it, but similar to how we have an event that you'd need to know about...
- 🇦🇹Austria agoradesign
ok, I see, we also need to fix the $breakdown.. but anyway, this can be done inside CheckoutOrderRequestEvent as well, so having this extra event would still be valuable imho
- 🇦🇹Austria agoradesign
@jsacksick I haven't really recognized your comment on friday. just saw it :D
hmm well, yes it is specific, but I believe we should be open to custom adjustment types, allowing them to have a solid way to integrate themselves. why should it harm to use events?
We have actually 2 different places inside prepareOrderRequest(), where we deal with an hardcoded opinionated list of adjustment types (skip, discount). my latest commit considers both (I have added in total 2 events, re-using the same event class)