Contrib.social

Explicit priority not being excluded from default priority

Open on Drupal.org →
Created on 7 November 2024, 6 months ago

Problem/Motivation

In SplitImportExportSubscriber, the method ::getDefaultPrioritySplitConfigs() doesn't follow the same convention as ::getSubscribedEvents() for Settings::get('config_split_priorities', []), resulting in the priority instead of the name being compared against split names.

Consequently, splits with explicit priorities are being run twice. This means that partial splits without patching are not detecting any changed value and thus not exporting, because on the second transform of the same split the value is being compared with the now reverted sync storage value.

Steps to reproduce

  1. Create split priority, configure $settings['config_split_priorities'] (to any priority), and rebuild container.
  2. Configure split to partially split core.date_format.* and tick 'Do not patch dependents'.
  3. Change any date format pattern.
  4. Export config.

The configured split does not contain any export.

Proposed resolution

Use array_keys() for $explicit to follow the same array usage convention.

Remaining tasks

Merge request with fix and tests to be posted.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇦🇺Australia zhangtaihao

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024