- Issue created by @aadownie
The string for getting and setting the table selector had the wrong format, I also removed some debug code from JavaScript that was outputting some messages to the console.
- πΊπΈUnited States bronzehedwick New York
Thanks @javi-er!
I tested this functionally and am still seeing the issue.
My Steps
- Check out this branch
- Copy the module into a fresh Drupal install, inside
themes/contrib
- Enable the module:
ddev drush en -y ckeditor_responsive_table
- Add the "Responsive Table" and "Table" buttons to the Basic text filter
- Create a basic page
- Insert a responsive table
- Insert a regular table
- Observe both are getting the responsive table enhancements
Is there something I'm missing?
@bronzehedwick yes! sorry, I should have left a comment with the test steps, you should go to the configuration at `admin/config/content/ckeditor-responsive-table` and enter a selector that will not target any tables for instance I used `table.ignore_all` which targets tables only with the `ignore_all` class which doesn't exists. So no tables should get the plugin treatment.
- πΊπΈUnited States bronzehedwick New York
Gotcha, thanks @javi-er! I re-tested following your steps, and things are working as expected! I had to clear cache, but I think that's normal.
-
javi-er β
committed d2c022c5 on 1.0.x
Issue #3485983: All tables are responsive regardless of selector setting
-
javi-er β
committed d2c022c5 on 1.0.x
Automatically closed - issue fixed for 2 weeks with no activity.