Remove HookOrder

I think if we're not sure about it, we should remove it - we can add it back in 11.2 or we can jump to [#Before]/[#After] attributes. But once it's in a tagged release it'll be much harder to remove/change.

I thought this would be entangled but I guess we haven't converted anything to use it yet.

Bumping to critical and beta target because this has to happen before 11.1.0 is tagged if it's going to happen at all before 12.0 is tagged.

rtbc +1

Since this is RTBC I went ahead and removed the relevant section in the change record so people don't start using it.

Please continue not crediting me here there and everywhere.

The challenge with Before/After is it's not possible to move hook implementations than ours. Is this really a problem?

I think these are useful even if there's a different way to remove or relocate hook implementations from other modules.

Your comment did make we wonder if we could add Replaces, this is one of the other major use cases for hook_module_implements_alter(). I think it's rare to purely want to re-order someone elses implementation rather than putting yours first/last so that could maybe be left to custom compiler passes.

Committed/pushed to 11.x and 11.1.x, thanks! We're only removing code we just added here so feels OK to commit with the additional +1x.

catch → closed merge request !10064

Automatically closed - issue fixed for 2 weeks with no activity.