Contrib.social

On Drupal 10.1 or later styles are not applied to the generated PDF but in HTML debug they are due to the aggregated CSS files are no longer generated during HTML rendering

Open on Drupal.org →
Created on 5 November 2024, 5 months ago

Problem/Motivation

Debugging before PostRenderSubscriber, this is the generated HTML:

<html>
<head>
  <meta charset="utf-8">
  <title>PDF megtekintése</title>
  <link rel="stylesheet" media="all" href="/sites/default/files/css/css_R0H3Hd9ODBL9mxnFSxoZL512fNd7n8qVW7cnTchKJTk.css?delta=0&amp;language=hu&amp;theme=base&amp;include=eJzLTTTXLyjKzCvRLS6pzMnMS9dJzSvJLKmMBwvqp6SmJZbmlAAAHn4PAg" />
<link rel="stylesheet" media="all" href="/sites/default/files/css/css_P7ftHhb4cVB-E_ycnH7E7DC1PUi1Gw_OxDep6pV5Lls.css?delta=1&amp;language=hu&amp;theme=base&amp;include=eJzLTTTXLyjKzCvRLS6pzMnMS9dJzSvJLKmMBwvqp6SmJZbmlAAAHn4PAg" />
</head>

After PostRenderSubscriber these become file:// links.

<!DOCTYPE html>
<html><head>
  <meta charset="utf-8">
  <title>PDF megtekintése</title>
  <link rel="stylesheet" media="all" href="file:///app/sites/default/files/css/css_R0H3Hd9ODBL9mxnFSxoZL512fNd7n8qVW7cnTchKJTk.css?delta=0&amp;language=hu&amp;theme=base&amp;include=eJzLTTTXLyjKzCvRLS6pzMnMS9dJzSvJLKmMBwvqp6SmJZbmlAAAHn4PAg">
<link rel="stylesheet" media="all" href="file:///app/sites/default/files/css/css_P7ftHhb4cVB-E_ycnH7E7DC1PUi1Gw_OxDep6pV5Lls.css?delta=1&amp;language=hu&amp;theme=base&amp;include=eJzLTTTXLyjKzCvRLS6pzMnMS9dJzSvJLKmMBwvqp6SmJZbmlAAAHn4PAg">
</head>

But due to how Drupal 10.1 or later does the JS and CSS aggregation, these CSS files are not generated. See core change documentation: https://www.drupal.org/node/3301716 → So displaying them with file:// links result to 404 errors and no styles applied to the PDF.

Steps to reproduce

Proposed resolution

Do not use the file:// protocol and use the same code as entity_print uses, meaning setting proper base URL to the links and attached file URLs.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.1

Component

Code

Created by

🇸🇰Slovakia kaszarobert

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kaszarobert
  • Comment 5 months ago →
    🇸🇰Slovakia kaszarobert

    I replaced the PostRenderSubscriber code with almost the same as what is used in modules/contrib/entity_print/src/EventSubscriber/PostRenderSubscriber.php and that way it starts working again.

  • Comment 5 months ago →
    🇸🇰Slovakia kaszarobert

    Alright, we're experiencing constant timeouts and higher database load in production with my previous solution.

    The main problem is Drupal does not generate the CSS files during generating the HTML and due to the slowness with web requests is see that only current the file:// method is viable.

    I have no other idea than disabling the CSS aggregation in the parent entity_print module. And I attach my quick fix for that. But again note that this patch is for entity_print, not for entity_print_chrome!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024